Yair Zaslavsky has posted comments on this change.
Change subject: engine: Gluster task monitoring for tasks started from CLI
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 92: List<Step> steps =
getStepDao().getStepsByExternalId(taskId);
Line 93: if (steps == null || steps.isEmpty()) {
Line 94: // the task may have been started from the CLI
Line 95: // need to add job to monitor
Line 96: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Several questions here -
a. In case one transaction fails, do we want the rest to succeed?
b. If not - consider using a single transaction for the loop + the batch
support.
Line 97:
Line 98: @Override
Line 99: public Void runInTransaction() {
Line 100: try {
--
To view, visit http://gerrit.ovirt.org/19183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb6385cbcad988351f23bda2294c8e85dde54560
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
