Alon Bar-Lev has posted comments on this change. Change subject: ovirt-live: prepare ovirt-live for ovirt 3.3 ......................................................................
Patch Set 1: (2 comments) also remove last empty lines from all files... :) .................................................... File centos/build.sh Line 10 Line 11 Line 12 Line 13 Line 14 what do you mean lack of proper conditions? .................................................... File centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py Line 168: ), Line 169: osetuputil.getGid( Line 170: osetupcons.Defaults.DEFAULT_SYSTEM_GROUP_KVM Line 171: ) Line 172: ) you should read the file content (source) and use filetransaction to create the target. this way you play nicely with the transaction of the installer. Line 173: Line 174: @plugin.event( Line 175: stage=plugin.Stages.STAGE_CLOSEUP, Line 176: condition=lambda self: self._enabled, -- To view, visit http://gerrit.ovirt.org/19200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3930256ebddb4eed912d216922861f7593d93dea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
