Alon Bar-Lev has posted comments on this change. Change subject: ovirt-live: prepare ovirt-live for ovirt 3.3 ......................................................................
Patch Set 2: (2 comments) .................................................... File centos/oVirtLiveFiles/root/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/olive/core.py Line 184: MB = 1024*1024 Line 185: GB = 1024*MB Line 186: Line 187: # Create VM Line 188: self._engine_api.vms.add( if that returs vm object, then better to use: vm = self.xxxx.add() and then use vm bellow instead of getting every time. Line 189: params.VM( Line 190: name='local_vm', Line 191: memory=1*GB, Line 192: os = params.OperatingSystem( Line 188: self._engine_api.vms.add( Line 189: params.VM( Line 190: name='local_vm', Line 191: memory=1*GB, Line 192: os = params.OperatingSystem( no spaces between kw and =.. Line 193: type_='unassigned', Line 194: boot=( Line 195: params.Boot(dev='cdrom'), Line 196: params.Boot(dev='hd'), -- To view, visit http://gerrit.ovirt.org/19200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3930256ebddb4eed912d216922861f7593d93dea Gerrit-PatchSet: 2 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Ohad Basan <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
