Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: backend: getLdapServers() use getCanonicalHostName
......................................................................

backend: getLdapServers() use getCanonicalHostName

Manage-domains tool will try to resolve FQDNs of machines that are
provided using -ldapServers, prior to adding a domain.

Change-Id: Ibae81ccd6b2a402c856934839f1dbdad316bbc3d
Bug-URL: https://bugzilla.redhat.com/show_bug.cgi?id=1001976
Signed-off-by: Douglas Schilling Landgraf <[email protected]>
---
M 
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/19547/1

diff --git 
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
 
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
index c98da1c..1e322e2 100644
--- 
a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
+++ 
b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
@@ -14,6 +14,8 @@
 import java.io.InputStream;
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.net.UnknownHostException;
+import java.net.InetAddress;
 import java.sql.SQLException;
 import java.text.SimpleDateFormat;
 import java.util.ArrayList;
@@ -462,6 +464,14 @@
             LdapSRVLocator locator = new LdapSRVLocator();
             DnsSRVResult ldapDnsResult = null;
             boolean foundServers = true;
+
+            try {
+                InetAddress ia = InetAddress.getByName(domainName);
+                ia.getCanonicalHostName();
+            } catch (UnknownHostException e) {
+                foundServers = false;
+            }
+
             try {
                 ldapDnsResult = locator.getLdapServers(domainName);
                 if (!foundSrvRecords(ldapDnsResult)) {


-- 
To view, visit http://gerrit.ovirt.org/19547
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibae81ccd6b2a402c856934839f1dbdad316bbc3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to