Yair Zaslavsky has posted comments on this change.
Change subject: backend: getLdapServers() use getCanonicalHostName
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java
Line 465: DnsSRVResult ldapDnsResult = null;
Line 466: boolean foundServers = true;
Line 467:
Line 468: try {
Line 469: InetAddress ia = InetAddress.getByName(domainName);
domainName is not the host name.
In addition, the check should be done only if ldapServers is provided. You need
to check that for example - ldapserver1.acme.com is indeed resolvable.
Line 470: ia.getCanonicalHostName();
Line 471: } catch (UnknownHostException e) {
Line 472: foundServers = false;
Line 473: }
--
To view, visit http://gerrit.ovirt.org/19547
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibae81ccd6b2a402c856934839f1dbdad316bbc3d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
