Omer Frenkel has posted comments on this change.
Change subject: engine: Refactoring of VmTemplateHandler editable fields
......................................................................
Patch Set 2:
(2 comments)
minor comments, looks good! thanks!
roy please look as well
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 117:
Line 118: @EditableField
Line 119: private boolean autoStartup;
Line 120:
Line 121: @EditableOnVmStatusField
missing editableOnTemplate here
Line 122: private boolean stateless;
Line 123:
Line 124: @EditableField
Line 125: private boolean deleteProtected;
Line 229: groups = { CreateEntity.class, UpdateEntity.class },
Line 230: message = "VALIDATION.VM.INVALID_KEYBOARD_LAYOUT")
Line 231: private String vncKeyboardLayout;
Line 232:
Line 233: @EditableOnVm
@michal i know its currently not editable for template, but is there any reason
for that? we can make it editable while we are at it
Line 234: private int minAllocatedMem;
Line 235:
Line 236: @EditableField
Line 237: private boolean runAndPause;
--
To view, visit http://gerrit.ovirt.org/19410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd933e14310cf8f58280448a580ed761169f777
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
