Michal Skrivanek has posted comments on this change.
Change subject: engine: Refactoring of VmTemplateHandler editable fields
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 50: @EditableField
Line 51: private int osId;
Line 52:
Line 53: @EditableOnVm
Line 54: private Date creationDate;
what's this anyway? not in GUI, right? Then why change it?
Line 55:
Line 56: @EditableField
Line 57: @Size(max = BusinessEntitiesDefinitions.VM_DESCRIPTION_SIZE)
Line 58: @ValidDescription(message =
"ACTION_TYPE_FAILED_DESCRIPTION_MAY_NOT_CONTAIN_SPECIAL_CHARS",
Line 229: groups = { CreateEntity.class, UpdateEntity.class },
Line 230: message = "VALIDATION.VM.INVALID_KEYBOARD_LAYOUT")
Line 231: private String vncKeyboardLayout;
Line 232:
Line 233: @EditableOnVm
yes, sure
Line 234: private int minAllocatedMem;
Line 235:
Line 236: @EditableField
Line 237: private boolean runAndPause;
--
To view, visit http://gerrit.ovirt.org/19410
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd933e14310cf8f58280448a580ed761169f777
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
