Kanagaraj M has posted comments on this change.
Change subject: gluster: Corrected the alert message for rebalance
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
minor comment
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
Line 40: }
Line 41:
Line 42: if (!glusterVolume.getVolumeType().isDistributedType()) {
Line 43: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_NOT_DISTRIBUTED);
Line 44: } else if (glusterVolume.getVolumeType().isDistributedType()
&& glusterVolume.getBricks().size() == 1) {
glusterVolume.getVolumeType().isDistributedType() is redundant
Line 45: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_DISTRIBUTED_AND_HAS_SINGLE_VOLUME);
Line 46: }
Line 47:
Line 48: return true;
--
To view, visit http://gerrit.ovirt.org/19570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I449d86daca772a1557e94d9f01cf5a170c749782
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
