Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Corrected the alert message for rebalance ......................................................................
Patch Set 3: (3 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-09-25 15:06:48 +0530 Line 4: Commit: Shubhendu Tripathi <[email protected]> Line 5: CommitDate: 2013-09-27 11:38:52 +0530 Line 6: Line 7: gluster: Corrected the alert message for rebalance Will do the changes Line 8: Line 9: Corrected the alert message for gluster volume rebalance command on case Line 10: there is a single brick in the volume. The new message is "Cannot Line 11: ${action} ${type}. Gluster Volume has a single brick." Line 5: CommitDate: 2013-09-27 11:38:52 +0530 Line 6: Line 7: gluster: Corrected the alert message for rebalance Line 8: Line 9: Corrected the alert message for gluster volume rebalance command on case Will do the changes Line 10: there is a single brick in the volume. The new message is "Cannot Line 11: ${action} ${type}. Gluster Volume has a single brick." Line 12: Line 13: Change-Id: I449d86daca772a1557e94d9f01cf5a170c749782 .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java Line 41: Line 42: boolean isVolumeDistributed = glusterVolume.getVolumeType().isDistributedType(); Line 43: if (!isVolumeDistributed) { Line 44: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_NOT_DISTRIBUTED); Line 45: } else if (isVolumeDistributed && glusterVolume.getBricks().size() == 1) { Yes, will remove the redundant code Line 46: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_DISTRIBUTED_AND_HAS_SINGLE_VOLUME); Line 47: } Line 48: Line 49: return true; -- To view, visit http://gerrit.ovirt.org/19570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I449d86daca772a1557e94d9f01cf5a170c749782 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
