Roy Golan has posted comments on this change.

Change subject: core: fix sound device check when adding devices from ovf 
(#1004066)
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 814:             }
Line 815:             if 
(vmDevice.getDevice().equals(VmDeviceType.CDROM.getName())){
Line 816:                 hasCD = true;
Line 817:             }
Line 818:             if (vmDevice.getType() == VmDeviceGeneralType.SOUND) {
please look at VmDeviceCommonUtils
Line 819:                 hasSoundCard = true;
Line 820:             }
Line 821:             vmDeviceToAdd.add(vmDevice);
Line 822:         }


-- 
To view, visit http://gerrit.ovirt.org/19561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to