Omer Frenkel has posted comments on this change.
Change subject: core: fix sound device check when adding devices from ovf
(#1004066)
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Line 37: return device.getType() == VmDeviceGeneralType.DISK
Line 38: &&
device.getDevice().equals(VmDeviceType.CDROM.getName());
Line 39: }
Line 40:
Line 41: public static boolean isSound(VmDevice device) {
i agree, well except the fact vmDevice is a class, not an enum :)
Line 42: return device.getType() == VmDeviceGeneralType.SOUND;
Line 43: }
Line 44:
Line 45: /**
--
To view, visit http://gerrit.ovirt.org/19561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
