Omer Frenkel has posted comments on this change.
Change subject: core, engine, webadmin: Initial support for alternative
architectures
......................................................................
Patch Set 5:
(2 comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
Line 210:
entity.setClusterPolicyName(rs.getString("cluster_policy_name"));
Line 211:
entity.setClusterPolicyProperties(SerializationFactory.getDeserializer()
Line 212:
.deserializeOrCreateNew(rs.getString("cluster_policy_custom_properties"),
LinkedHashMap.class));
Line 213:
entity.setEnableBallooning(rs.getBoolean("enable_balloon"));
Line 214:
entity.setArchitecture(ArchitectureType.forValue(rs.getInt("architecture")));
right, sorry i dont know why i was confused!
Line 215: return entity;
Line 216: }
Line 217: }
Line 218:
....................................................
File packaging/dbscripts/upgrade/03_03_0900_add_architecture_name_column.sql
Line 4: -- Existent clusters with cpu_name are x86_64, since alternative
architectures are introduced after this upgrade
Line 5: UPDATE vds_groups SET architecture = 1 where cpu_name is not NULL and
architecture = 0;
Line 6:
Line 7: -- Update clusters
Line 8: create or replace FUNCTION __temp_update_vds_group()
the cpu has to match the hosts that will be added to the cluster, i'm affraid
setting this cpu will cause troubles if user will try to add intel hosts to the
cluster.
i wonder if we can just set the arch to x86_64, and leave the cpu null,
then when hosts will be added to the cluster, updateVdsGroupCommand will update
the cpu (as done already) and if ppc host will be added, it will fail to
update the cluster and host will not be up until user will fix this.
what do you think?
Line 9: returns void
Line 10: AS $procedure$
Line 11: declare
Line 12: r vds_groups%rowtype;
--
To view, visit http://gerrit.ovirt.org/18938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ecd642e2bc05067d55884c948bdaeb6e7838c26
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
