Sandro Bonazzola has posted comments on this change. Change subject: core: log: add indirect filtering ......................................................................
Patch Set 1: (1 comment) .................................................... File src/plugins/otopi/core/log.py Line 84: def format(self, record): Line 85: msg = logging.Formatter.format(self, record) Line 86: Line 87: for f in ( Line 88: self.environment[constants.CoreEnv.LOG_FILTER]._list + I think that accessing private attributes of other objects is not a good practice, can't it be avoided? Line 89: [ Line 90: self.environment[k] for k in Line 91: self.environment[constants.CoreEnv.LOG_FILTER_KEYS] Line 92: ] -- To view, visit http://gerrit.ovirt.org/19782 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96a70f5450f9416583b7803dfe7a10aa6c98472 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
