Sandro Bonazzola has posted comments on this change.

Change subject: core: log: add indirect filtering
......................................................................


Patch Set 1:

> Adding public property will expose this list to the public while I try to 
> avoid that for sensitive data.

> It is private by design.

I understand the point also if I don't think that using the private access may 
prevent in any way public to access that variable. However it's not so 
important in this specific case avoiding to use the private access.

-- 
To view, visit http://gerrit.ovirt.org/19782
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id96a70f5450f9416583b7803dfe7a10aa6c98472
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to