Sergey Gotliv has uploaded a new change for review. Change subject: engine: getImagesList API does not return GetStorageDomainListError ......................................................................
engine: getImagesList API does not return GetStorageDomainListError Change-Id: I56d639d83bd24e6b3939933998d17c5498670b5a Signed-off-by: Sergey Gotliv <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImagesListVDSCommand.java 1 file changed, 6 insertions(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/58/19858/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImagesListVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImagesListVDSCommand.java index 3fa4702..14ea66b 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImagesListVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImagesListVDSCommand.java @@ -10,7 +10,7 @@ public class GetImagesListVDSCommand<P extends GetImagesListVDSCommandParameters> extends IrsBrokerCommand<P> { - private ImagesListReturnForXmlRpc _result; + private ImagesListReturnForXmlRpc result; public GetImagesListVDSCommand(P parameters) { super(parameters); @@ -18,10 +18,10 @@ @Override protected void executeIrsBrokerCommand() { - _result = getIrsProxy().getImagesList(getParameters().getStorageDomainId().toString()); + result = getIrsProxy().getImagesList(getParameters().getStorageDomainId().toString()); proceedProxyReturnValue(); - ArrayList<Guid> tempRetValue = new ArrayList<Guid>(_result.getImageList().length); - for (String id : _result.getImageList()) { + ArrayList<Guid> tempRetValue = new ArrayList<Guid>(result.getImageList().length); + for (String id : result.getImageList()) { tempRetValue.add(new Guid(id)); } setReturnValue(tempRetValue); @@ -29,25 +29,11 @@ @Override protected StatusForXmlRpc getReturnStatus() { - return _result.mStatus; + return result.mStatus; } @Override protected Object getReturnValueFromBroker() { - return _result; - } - - @Override - protected void proceedProxyReturnValue() { - VdcBllErrors returnStatus = GetReturnValueFromStatus(getReturnStatus()); - switch (returnStatus) { - case GetStorageDomainListError: - getVDSReturnValue().setVdsError(new VDSError(returnStatus, getReturnStatus().mMessage)); - getVDSReturnValue().setSucceeded(false); - break; - default: - super.proceedProxyReturnValue(); - break; - } + return result; } } -- To view, visit http://gerrit.ovirt.org/19858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I56d639d83bd24e6b3939933998d17c5498670b5a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
