Allon Mureinik has posted comments on this change. Change subject: engine: getImagesList API does not return GetStorageDomainListError ......................................................................
Patch Set 2: Code-Review+1 (1 comment) .................................................... Commit Message Line 3: AuthorDate: 2013-10-04 01:06:32 +0300 Line 4: Commit: Sergey Gotliv <[email protected]> Line 5: CommitDate: 2013-10-04 01:17:57 +0300 Line 6: Line 7: engine: getImagesList API does not return GetStorageDomainListError The commit message is not explanatory. By reading the code, it's evident that this api CAN'T return GetStorageDomainListError so there's no need to handle it, but this needs to be described in the commit message. Line 8: Line 9: Change-Id: I56d639d83bd24e6b3939933998d17c5498670b5a -- To view, visit http://gerrit.ovirt.org/19858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I56d639d83bd24e6b3939933998d17c5498670b5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
