Shubhendu Tripathi has posted comments on this change.
Change subject: gluster: add glusterfs version into host detail view
......................................................................
Patch Set 2:
(4 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
Line 515: public void setkernel_version(String value) {
Line 516: this.kernel_version = value;
Line 517: }
Line 518:
Line 519: public String getgluster_version() {
Method names are not as per java coding standards.
Use camelCase mechanism for method names.
Line 520: return this.gluster_version;
Line 521: }
Line 522:
Line 523: public void setgluster_version(String value) {
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java
Line 126: public static final String HBAInventory = "HBAInventory";
Line 127: public static final String qemuKvmPackageName = "qemu-kvm";
Line 128: public static final String vdsmPackageName = "vdsm";
Line 129: public static final String spiceServerPackageName =
"spice-server";
Line 130: public static final String glusterPackageName = "glusterfs";
final variables should be defined in ALL caps and underscores as separator.
Line 131:
Line 132: public static final String mem_available = "memAvailable";
Line 133: public static final String memFree = "memFree";
Line 134: public static final String mem_shared = "memShared";
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 3286: @DefaultStringValue("Rebalance NOT STARTED")
Line 3287: String rebalanceNotStarted();
Line 3288:
Line 3289: @DefaultStringValue("GLUSTER Version")
Line 3290: String glusterVersionHostGeneral();
This name is not intuitive and we can not make out what it is meant for as
others do.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
Line 156: formBuilder.addFormItem(new
FormItem(constants.sharedMemHostGeneral(), sharedMemory, 2, 2));
Line 157: formBuilder.addFormItem(new
FormItem(constants.maxSchedulingMemory(), maxSchedulingMemory, 3, 2,
virtSupported));
Line 158: formBuilder.addFormItem(new
FormItem(constants.memPageSharingHostGeneral(), memoryPageSharing, 4, 2));
Line 159: formBuilder.addFormItem(new
FormItem(constants.autoLargePagesHostGeneral(), automaticLargePage, 5, 2));
Line 160: formBuilder.addFormItem(new
FormItem(constants.isciInitNameHostGeneral(), iScsiInitiatorName, 6, 2,
virtSupported));
You code could have been at the last instead of modifying one existing one and
then adding at last.
Line 161: }
Line 162:
Line 163: void initMemorySizeLabels() {
Line 164: this.physicalMemory = new MemorySizeLabel<Integer>(constants);
--
To view, visit http://gerrit.ovirt.org/19862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe7feeb4de647ba525bcdccf3f3513a2702796e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
