Sahina Bose has posted comments on this change.
Change subject: gluster: add glusterfs version into host detail view
......................................................................
Patch Set 2:
(6 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
Line 78: private RpmVersion libvirt_version;
Line 79:
Line 80: private String spice_version;
Line 81:
Line 82: private String gluster_version;
Shouldn't this be RpmVersion?
Line 83:
Line 84: private String kernel_version;
Line 85:
Line 86: private String iScsiInitiatorName;
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 242: }
Line 243:
Line 244: public void setGlusterVersion(String value)
Line 245: {
Line 246: if (this.glusterVersion == null ||
!this.glusterVersion.equals(value))
use StringHelper
Line 247: {
Line 248: this.glusterVersion = value;
Line 249: onPropertyChanged(new
PropertyChangedEventArgs("GlusterVersion")); //$NON-NLS-1$
Line 250: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
Line 3286: @DefaultStringValue("Rebalance NOT STARTED")
Line 3287: String rebalanceNotStarted();
Line 3288:
Line 3289: @DefaultStringValue("GLUSTER Version")
Line 3290: String glusterVersionHostGeneral();
Move this next to the other version fields, and the string value should be
"GlusterFS Version"
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java
Line 140: formBuilder.addFormItem(new
FormItem(constants.kvmVersionHostGeneral(), kvmVersion, 2, 0, virtSupported));
Line 141: formBuilder.addFormItem(new
FormItem(constants.libvirtVersionHostGeneral(), libvirtVersion, 3, 0,
virtSupported));
Line 142: formBuilder.addFormItem(new
FormItem(constants.vdsmVersionHostGeneral(), vdsmVersion, 4, 0));
Line 143: formBuilder.addFormItem(new
FormItem(constants.spiceVersionHostGeneral(), spiceVersion, 5, 0,
virtSupported));
Line 144: formBuilder.addFormItem(new
FormItem(constants.glusterVersionHostGeneral(), glusterVersion, 6, 0,
virtSupported));
Should be glusterSupported - not virtSupported
Line 145:
Line 146: formBuilder.addFormItem(new FormItem(constants.spmPriority(),
spmPriority, 0, 1, virtSupported));
Line 147: formBuilder.addFormItem(new
FormItem(constants.activeVmsHostGeneral(), activeVms, 1, 1, virtSupported));
Line 148: formBuilder.addFormItem(new
FormItem(constants.cpuNameHostGeneral(), cpuName, 2, 1));
Line 156: formBuilder.addFormItem(new
FormItem(constants.sharedMemHostGeneral(), sharedMemory, 2, 2));
Line 157: formBuilder.addFormItem(new
FormItem(constants.maxSchedulingMemory(), maxSchedulingMemory, 3, 2,
virtSupported));
Line 158: formBuilder.addFormItem(new
FormItem(constants.memPageSharingHostGeneral(), memoryPageSharing, 4, 2));
Line 159: formBuilder.addFormItem(new
FormItem(constants.autoLargePagesHostGeneral(), automaticLargePage, 5, 2));
Line 160: formBuilder.addFormItem(new
FormItem(constants.isciInitNameHostGeneral(), iScsiInitiatorName, 6, 2,
virtSupported));
I think this is ok as the we need the gluster version to appear after other
version info
Line 161: }
Line 162:
Line 163: void initMemorySizeLabels() {
Line 164: this.physicalMemory = new MemorySizeLabel<Integer>(constants);
....................................................
File packaging/dbscripts/create_tables.sql
Line 462: supported_cluster_levels VARCHAR(40),
Line 463: host_os VARCHAR(4000),
Line 464: kvm_version VARCHAR(4000),
Line 465: spice_version VARCHAR(4000),
Line 466: gluster_version VARCHAR(4000),
Should be a separate script - as we are modifying existing table
Line 467: kernel_version VARCHAR(4000),
Line 468: iscsi_initiator_name VARCHAR(4000),
Line 469: transparent_hugepages_state INTEGER NOT NULL DEFAULT '0',
Line 470: anonymous_hugepages INTEGER NOT NULL DEFAULT '0',
--
To view, visit http://gerrit.ovirt.org/19862
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe7feeb4de647ba525bcdccf3f3513a2702796e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
