Frank Kobzik has posted comments on this change.
Change subject: core: Remove Windows ProductKey* from db
......................................................................
Patch Set 3:
(1 comment)
....................................................
File packaging/dbscripts/upgrade/03_03_0950_extract_product_keys.sh.in
Line 42: execute_command "${CMD}" "${DATABASE}" "${SERVERNAME}" "${PORT}" | \
Line 43: tail -n+2 | \
Line 44: sed -e 's/^ *//' -e 's/ *$//' -e 's/ *| */|/g' | \
Line 45: grep -v '|$' | \
Line 46: sed -e $SED_RULES > $TMP_FILE
Hi Eli, we've been discussing this and we agreed on a fact that we don't want
the upgrade script to fail because of a little thing like this. In the worst
case, user would have to retype the product keys to os info repository. The
keys wouldn't be lost (in the worst case they can be pulled out of the db
backup). Are you ok with this?
Line 47:
Line 48: if [ -s $TMP_FILE ]; then
Line 49: cp $TMP_FILE $OSINFO_FILE
Line 50: fi
--
To view, visit http://gerrit.ovirt.org/19743
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
