Eli Mesika has posted comments on this change.

Change subject: core: Remove Windows ProductKey* from db
......................................................................


Patch Set 4:

(1 comment)

....................................................
File packaging/dbscripts/upgrade/03_03_0950_extract_product_keys.sh.in
Line 37: s/ProductKeyWindows8x64|/${prefix}windows_8x64${suffix}/;\
Line 38: s/ProductKeyWindows2012x64|/${prefix}windows_2012x64${suffix}/"
Line 39: 
Line 40: TMP_FILE=`mktemp`
Line 41: trap "rm -f $TMP_FILE" EXIT
trap dispatches on signals the process receives (e.g., from a kill), not on 
exit codes,
Am I missing something here ???
Line 42: 
Line 43: CMD="select option_name, option_value from vdc_options where 
option_name in ($OPTIONS_NAMES_WITH_COMMAS)"
Line 44: execute_command "${CMD}" "${DATABASE}" "${SERVERNAME}" "${PORT}" | \
Line 45:     tail -n+2 | \


-- 
To view, visit http://gerrit.ovirt.org/19743
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I876894e7ba5fcd28ee0d435b4a2561f662140174
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to