Roy Golan has posted comments on this change.
Change subject: core: CDI - EJB cleanup - Backend and Scheduler
......................................................................
Patch Set 2:
(3 comments)
* did you manage to figure why injection into root.war servlets doesn't work?
* is your jandex patch merged?
* if yes than I can get rid of the BllProviders workaround
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 81:
Line 82: @Inject
Line 83: private Log log;
Line 84: @Inject
Line 85: private SchedulerUtilQuartzImpl quartz;
will do
Line 86:
Line 87:
Line 88: public static BackendInternal getInstance() {
Line 89: return EjbUtils.findBean(BeanType.BACKEND,
BeanProxyType.LOCAL);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
Line 36: @Inject
Line 37: private Log log;
Line 38:
Line 39: @Inject
Line 40: Backend backend;
yes no reason to expose it
Line 41:
Line 42: @Override
Line 43: @PostConstruct
Line 44: public void create() {
....................................................
File
backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java
Line 44
Line 45
Line 46
Line 47
Line 48
it was done to impose some ordering. I'll check the commit message to see what
was the intention
--
To view, visit http://gerrit.ovirt.org/19887
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I126fa3f4240e81814ec9e902cb2e93ce364589ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
