Juan Hernandez has posted comments on this change. Change subject: core: CDI - EJB cleanup - Backend and Scheduler ......................................................................
Patch Set 2: > did you manage to figure why injection into root.war servlets doesn't work? I think that this doesn't work because weld doesn't consider the .war a bean archive and thus it doesn't process the injections. Usually one puts the .jar files with the beans.xml file inside the WEB-INF/lib directory, and that makes the .war a candidate for processing by weld, but we don't do so. I think that we can solve this putting a beans.xml file in the WEB-INF directory of web applications (except in RESTAPI, we can't put that there as it breaks other things). > is your jandex patch merged? No, it isn't merged. Please review it (the patch that adds support to create the jandex indexes and the patch that actually creates them): http://gerrit.ovirt.org/13712 http://gerrit.ovirt.org/13713 Note however that this doesn't solve the problem of CDI annotations inside modules. > if yes than I can get rid of the BllProviders workaround We need this workaround even if the two patches mentioned above are merged, as there is a limitation in JBoss AS 7 in these regards. -- To view, visit http://gerrit.ovirt.org/19887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I126fa3f4240e81814ec9e902cb2e93ce364589ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
