Gilad Chaplik has posted comments on this change.
Change subject: core: Log filtering progress in scheduling
......................................................................
Patch Set 5:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 680: errorMessage.append("All hosts were filtered out, the reasons
follow:\n");
Line 681: for (Map.Entry<Guid, String> vds:
schedulingResult.getReasons()) {
Line 682: errorMessage.append(String.format("%s: %s\n",
vds.getKey().toString(), vds.getValue()));
Line 683: }
Line 684: getReturnValue().setDescription(errorMessage.toString());
CMIIW, but shouldn't all the error treatment be in can do action part, i.e.
canSchedule?
Line 685:
Line 686: VmHandler.updateVmGuestAgentVersion(getVm());
Line 687: setVds(null);
Line 688: setVdsName(null);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 163: }
Line 164: }
Line 165: }
Line 166:
Line 167: public class SchedulingResult {
please move this class to a separate file, or declare it as static.
Line 168: Map<Guid, String> filteredOutReasons;
Line 169: String message;
Line 170: Guid vdsSelected = null;
Line 171:
Line 412: reason.append(" (");
Line 413: reason.append(host.getId().toString());
Line 414: reason.append(") was filtered out by ");
Line 415: reason.append(actionName);
Line 416: result.addReason(host.getId(), reason.toString());
where reason is going to be printed? btw, it's not localized
Line 417: log.info(reason);
Line 418: }
Line 419: }
Line 420: }
--
To view, visit http://gerrit.ovirt.org/19213
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
