Moti Asayag has posted comments on this change.
Change subject: engine: Modified external networks query
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/GetAllExternalNetworksOnProviderQuery.java
Line 30: List<Network> externalNetworks = client.getAll();
Line 31:
Line 32: Map<Network, Set<Guid>> externalNetworkToDcId = new
HashMap<Network, Set<Guid>>();
Line 33: for (Network network : externalNetworks) {
Line 34: List<Guid> dcIds =
getDbFacade().getStoragePoolDao().getDcIdByExternalNetworkId(network.getProvidedBy().getExternalId());
what about replacing the inner 'for' loop with ?
new HashSet<Guid>(dcIds);
so eventually we'll get:
externalNetworkToDcId.put(network, new HashSet<Guid>(dcIds));
Line 35: Set<Guid> dataCenterIds = new HashSet<Guid>();
Line 36: for (Guid dcId : dcIds) {
Line 37: dataCenterIds.add(dcId);
Line 38: }
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StoragePoolDAOTest.java
Line 228:
Line 229: /**
Line 230: * Ensures that all data centers where a specific external
network has been imported are returned.
Line 231: */
Line 232: @Test
this is entitled for 2 separated tests.
Line 233: public void testGetDataCentersByExternalNetworkId() {
Line 234: List<Guid> result =
dao.getDcIdByExternalNetworkId(FixturesTool.EXTERNAL_NETWORK_ID);
Line 235: List<Guid> emptyResult =
dao.getDcIdByExternalNetworkId("foo");
Line 236:
--
To view, visit http://gerrit.ovirt.org/19980
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd9d918dabc0930d1801678f405c954d95228003
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
