Lior Vernia has posted comments on this change. Change subject: engine: Modified external networks query ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/dbscripts/storages_sp.sql Line 724: END; $procedure$ Line 725: LANGUAGE plpgsql; Line 726: Line 727: Line 728: CREATE OR REPLACE FUNCTION GetDcIdByExternalNetworkId(v_external_id text) Sorry guys, I was kinda stupid leaving the INNER JOIN, it's residue from an older patchset. There's actually no reason to access the storage_pool table anymore, and I'll move everything to networks_sp and NetworkDao. The only question that remains is if I should add an index for network.provider_network_external_id, and keep in mind that the field's type is text. Eli? Line 729: RETURNS SETOF UUID STABLE Line 730: AS $procedure$ Line 731: BEGIN Line 732: RETURN QUERY -- To view, visit http://gerrit.ovirt.org/19980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd9d918dabc0930d1801678f405c954d95228003 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
