Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: revert nfs config on cleanup
......................................................................
Patch Set 9:
(4 comments)
Thanks!
....................................................
File packaging/setup/ovirt_engine_setup/util.py
Line 43: def editConfigContent(
Line 44: content,
Line 45: params,
Line 46: changed_lines=None,
Line 47: comment_re='[#]*\s*',
#* is not enough?
Line 48: comment='# ',
Line 49: separator_re='\s*=\s*',
Line 50: separator=' = ',
Line 51: ):
Line 44: content,
Line 45: params,
Line 46: changed_lines=None,
Line 47: comment_re='[#]*\s*',
Line 48: comment='# ',
based on bellow... have this template? '# {original}'?
Line 49: separator_re='\s*=\s*',
Line 50: separator=' = ',
Line 51: ):
Line 52: """Return edited content of a config file.
Line 46: changed_lines=None,
Line 47: comment_re='[#]*\s*',
Line 48: comment='# ',
Line 49: separator_re='\s*=\s*',
Line 50: separator=' = ',
I was bit confused over this parameter... then read that it is only added. Then
thought of maybe have here '{name} = {value}' template?
Line 51: ):
Line 52: """Return edited content of a config file.
Line 53:
Line 54: Keyword arguments:
Line 69: Params that appear uncommented in the input, are commented, and new
Line 70: values are added after the commented lines. Params that appear only
Line 71: commented in the input, the comments are copied as-is, and new
lines
Line 72: are added after the comments. Params that do not appear in the
input
Line 73: are added in the end.
what I am missing for ssl.conf is before/after, for example if we edit xml like
configuration we need to add new lines before the closure.
Line 74: """
Line 75: # TODO: Add more options that will allow using this function
Line 76: # in other places. Examples:
Line 77: # setup/plugins/ovirt-engine-setup/apache/ssl.py
--
To view, visit http://gerrit.ovirt.org/19001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
