Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: revert nfs config on cleanup
......................................................................
Patch Set 10:
(3 comments)
....................................................
File packaging/setup/ovirt_engine_setup/util.py
Line 44: content,
Line 45: params,
Line 46: changed_lines=None,
Line 47: comment_re='[#]*\s*',
Line 48: new_comment_tpl='{spaces}# {original}',
template is a good term :)
Line 49: separator_re='\s*=\s*',
Line 50: new_line_tpl='{spaces}{param} = {value}',
Line 51: added_params=None,
Line 52: ):
Line 74: Params that appear uncommented in the input, are commented, and new
Line 75: values are added after the commented lines. Params that appear only
Line 76: commented in the input, the comments are copied as-is, and new
lines
Line 77: are added after the comments. Params that do not appear in the
input
Line 78: are added in the end.
so the only missing item for me is the barrier.
Line 79: """
Line 80: # TODO: Add more options that will allow using this function
Line 81: # in other places. Examples:
Line 82: # setup/plugins/ovirt-engine-setup/apache/ssl.py
....................................................
File packaging/test/README
please add tests framework in other patch.
please consider to use the Nose framework as vdsm does.
Line 1: simple test subdir for ovirt-engine packaging
Line 2: =============================================
Line 3:
Line 4: To test, run:
--
To view, visit http://gerrit.ovirt.org/19001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I74dd4c1556bd6479fcf10f85fcbe083f215e0854
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
