Ofer Schreiber has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 12: Code-Review+2 In the battle between "duplicating code" and "possible bugs", I'm in favor of the former. 3.4 Is not so far from us, and I suspect we will remove the legacy plugin before that release. keeping all the relevent legact stuff in one place, will protect us from future bugs. (I have to admit though, that both codes looks fine to me, as the share almost the same logic) -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
