Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: partial cleanup - db only ......................................................................
Patch Set 11: These argument can be summarize as... "I already wrote a piece of code, and I do not want to change it". I am totally against that approach. If we can revert the extra complexity in normal path, and lowering the dependencies between modules and especially these that are going to be obsoleted, we should invest 10 minutes to do that. The duplication is irrelevant, as it is much easier and more correct than overwriting a file. Writing these comments takes more than fixing this. -- To view, visit http://gerrit.ovirt.org/19689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id9aa1791eb7ccdbc8c679e72ed6eaa4f72ac29c6 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
