Alon Bar-Lev has posted comments on this change.
Change subject: engine: root.war cleanup
......................................................................
Patch Set 9:
(3 comments)
BEAUTIFUL!
Some minor questions...
And you need also to update the spec file, find:
# Move jars to destribution location
And install Makefile, find:
install_poms:
....................................................
File
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
Line 87: //to show in the jsp, except if I use <jsp-file> instead of
<servlet-class>.
Line 88: if (getServletConfig() != null) {
Line 89: request.setAttribute(APPLICATION_TYPE,
Line 90:
getServletConfig().getServletContext().getInitParameter(APPLICATION_TYPE));
Line 91: }
strange, what fails? what is <jsp-file> you are using?
Line 92: request.setAttribute(LOCALE_KEYS,
LocaleFilter.getLocaleKeys());
Line 93: String oVirtVersion =
backend.RunPublicQuery(VdcQueryType.GetConfigurationValue,
Line 94: new
GetConfigurationValueParameters(ConfigurationValues.ProductRPMVersion,
Line 95:
ConfigCommon.defaultConfigurationVersion)).getReturnValue();
....................................................
File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml
Line 78: <param-name>file</param-name>
Line 79: <param-value>%{ENGINE_MANUAL}</param-value>
Line 80: </init-param>
Line 81: <init-param>
Line 82: <param-name>forwardPath</param-name>
find a better name from forwardPath? something that localeMissingURI?
Line 83: <param-value>/ovirt-engine/docsmissing</param-value>
Line 84: </init-param>
Line 85: </servlet>
Line 86: <servlet-mapping>
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/PageNotFoundForwardServlet.java
Line 21: */
Line 22: private static final long serialVersionUID = -4938071390518075052L;
Line 23:
Line 24: private static final String ROOT_CONTEXT_PATH = "/"; //$NON-NLS-1$
Line 25: private static final String ROOT_404 = "/404.html"; //$NON-NLS-1$
move to init parameters so all metadata will be in one place?
Line 26:
Line 27: @Override
Line 28: protected void doGet(final HttpServletRequest request, final
HttpServletResponse response) throws IOException,
Line 29: ServletException {
--
To view, visit http://gerrit.ovirt.org/19848
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceae0ebf671efc951522c464db1a5b2b95dd5637
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
