Lior Vernia has posted comments on this change. Change subject: engine: Modified external networks query ......................................................................
Patch Set 4: (1 comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDao.java Line 109: * @param externalId Line 110: * the external network's external ID. Line 111: * @return the list of data center IDs. Line 112: */ Line 113: List<Guid> getDcIdByExternalNetworkId(String externalId); It's not just an implementation detail. The "main" entity in this query could just as well be considered the network. The DC ID in this context is just a key in the networks table, it's not used to retrieve the actual DC entity. -- To view, visit http://gerrit.ovirt.org/19980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd9d918dabc0930d1801678f405c954d95228003 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
