Vojtech Szocs has posted comments on this change. Change subject: core: Add GWT RPC serializable check ......................................................................
Patch Set 2: (1 comment) .................................................... Commit Message Line 31: Line 32: GwtRpcSerializableCheck uses Java Reflection API instead of Line 33: Checkstyle's AST Token API. This is because of advanced class Line 34: introspection (i.e. check if given class implements interface Line 35: X either directly or indirectly) required by this check. > When running checkstyle there is no guarantee that the code you're examining > is compiled or exists in your classpath. I think we have such guarantee. Engine root pom.xml tells maven-checkstyle-plugin to execute at "compile" phase. Quote from http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html "When multiple executions are given that match a particular phase, they are executed in the order specified in the POM, with inherited executions running first." I think maven-compiler-plugin counts as "inherited execution" - project Java classes will first be compiled and then maven-checkstyle-plugin executes with classpath containing these classes. Otherwise, any checks based on AbstractTypeAwareCheck would be broken anyway. Line 36: Line 37: GwtRpcSerializableCheck makes best effort not to load/check Line 38: given class more than once. Line 39: -- To view, visit http://gerrit.ovirt.org/18910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51c87efc432444226daa7a18be047435d21b84ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
