Vojtech Szocs has posted comments on this change. Change subject: core: Add GWT RPC serializable check ......................................................................
Patch Set 2: Thinking about it, maybe this check is an overkill, maybe we just need a smaller AST-use-only check for the default constructor. After all, if a class doesn't implement (Is)Serializable interface && doesn't have custom field serializer, it should blow up on error during GWT compilation. Same thing applies for fields of given class as GWT compiler inspects these too. Allon, would it make sense to abandon this patch and instead make a smaller AST-use-only check for the default constructor? -- To view, visit http://gerrit.ovirt.org/18910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51c87efc432444226daa7a18be047435d21b84ef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
