Liron Ar has posted comments on this change.
Change subject: core: Remove unexisting Storage Domain will be rolled forward.
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
Line 199: throw e;
Line 200: }
Line 201: log.warnFormat("Storage Domain {0} which was about to be
formatted does not exist in VDS {1}",
Line 202: dom.getName(),
Line 203: vds.getName());
perhaps my last comment was misunderstood :) please add also the id's along the
names, something similar is done @ IrsBrokerCommand.getDomainIdTuple
which is basically id:name
Line 204: return true;
Line 205: }
Line 206: }
Line 207:
--
To view, visit http://gerrit.ovirt.org/20158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9515a5ddfcaa965c2bad1883f0543494915b8c7d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
