Liron Ar has posted comments on this change.
Change subject: core: adding support for db lock of all disk snapshots
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 648: final ImageStatus status,
Line 649: ImageStatus statusForCompensation,
Line 650: final CompensationContext compensationContext) {
Line 651:
Line 652: if (compensationContext != null) {
Done
Line 653: List<DiskImage> diskSnapshots =
Line 654:
DbFacade.getInstance().getDiskImageDao().getAllSnapshotsForImageGroup(diskId);
Line 655: for (DiskImage diskSnapshot : diskSnapshots) {
Line 656: diskSnapshot.setImageStatus(statusForCompensation);
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
Line 114: Image image = dao.get(EXISTING_IMAGE_ID);
Line 115: List<DiskImage> snapshots =
dbFacade.getDiskImageDao().getAllSnapshotsForImageGroup(image.getDiskId());
Line 116: assertFalse(snapshots.size() == 1);
Line 117: for (DiskImage diskImage : snapshots) {
Line 118: assertFalse(ImageStatus.LOCKED ==
diskImage.getImageStatus());
there's no assertNotEquals -
http://junit.sourceforge.net/javadoc/org/junit/Assert.html
Line 119: }
Line 120: dao.updateStatusOfImagesByImageGroupId(image.getDiskId(),
ImageStatus.LOCKED);
Line 121: snapshots =
dbFacade.getDiskImageDao().getAllSnapshotsForImageGroup(image.getDiskId());
Line 122:
--
To view, visit http://gerrit.ovirt.org/20308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibac8daf6a9e970859a6759d84d7849e7f84e0d79
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
