Sergey Gotliv has posted comments on this change.
Change subject: core: adding support for db lock of all disk snapshots
......................................................................
Patch Set 8:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 139: protected Disk loadActiveDisk(Guid diskId) {
Line 140: return getDiskDao().get(diskId);
Line 141: }
Line 142:
Line 143:
This file can be removed from the patch.
Line 144: protected Disk loadDiskFromSnapshot(Guid diskId, Guid snapshotId)
{
Line 145: return getDiskImageDao().getDiskSnapshotForVmSnapshot(diskId,
snapshotId);
Line 146: }
Line 147:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 68: if (isImageDisk) {
Line 69: //TODO : this load and check of the active disk will be
removed
Line 70: // as update script for previous version for the status
illegal will be introduced.
Line 71: Disk activeDisk = loadActiveDisk(disk.getId());
Line 72:
This change seems to be not related to DB locks. If this is the case, this file
can be reverted.
Line 73: if (((DiskImage) activeDisk).getImageStatus() ==
ImageStatus.ILLEGAL) {
Line 74: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_DISK_OPERATION);
Line 75: }
Line 76:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 320:
getParameters().getStorageDomainId()));
Line 321:
ImagesHandler.updateAllDiskImageSnapshotsStatusWithCompensation(getRelevantDiskImage().getId(),
Line 322: getRelevantDiskImage().getImageStatus(),
Line 323: null,
Line 324: null);
Why don't you use other method - the one without compensation?
Line 325: return null;
Line 326: }});
Line 327: }
Line 328:
--
To view, visit http://gerrit.ovirt.org/20308
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibac8daf6a9e970859a6759d84d7849e7f84e0d79
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
