Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-backup: Prevent password on command line
......................................................................
Patch Set 3:
(3 comments)
....................................................
File packaging/bin/engine-backup.sh
Line 127: die "Can not read password file
${DB_PASSFILE}"
Line 128: read MY_DB_PASSWORD < "${DB_PASSFILE}"
Line 129: ;;
Line 130: --db-password)
Line 131: MY_DB_PASSWORD="$(readdbpassword)"
I suggest:
--db-password=*)
MY_DB_PASSWORD="${v}"
;;
--db-password)
MY_DB_PASSWORD="$(readdbpassword)"
;;
Line 132: ;;
Line 133: --db-name=*)
Line 134: MY_DB_DATABASE="${v}"
Line 135: ;;
Line 405:
Line 406: trap cleanup 0
Line 407: STTY_ORIG="$(stty -g)"
Line 408: stty -echo || \
Line 409: die "Failed to disable terminal input echo"
|| exit 1
Line 410: echo -n "Enter database password: " 1>&2
Line 411: read dbpass
Line 412: echo 1>&2
Line 413: cat << __EOF__
Line 412: echo 1>&2
Line 413: cat << __EOF__
Line 414: ${dbpass}
Line 415: __EOF__
Line 416: )
|| die "Failed to ..."
Line 417: }
Line 418:
Line 419: ## Main
Line 420:
--
To view, visit http://gerrit.ovirt.org/20423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
