Yedidyah Bar David has posted comments on this change.
Change subject: packaging: engine-backup: Prevent password on command line
......................................................................
Patch Set 2:
(1 comment)
....................................................
File packaging/bin/engine-backup.sh
Line 132: echo -n "Enter database password: "
Line 133: read MY_DB_PASSWORD
Line 134: stty "${STTY_ORIG}"
Line 135: echo
Line 136: STTY_ORIG=
BTW, with this (patchset 4), when reading the password, there are 3
engine-backup.sh processes:
1. top
2. created by the $()
3. created by the subshell in this function.
For some reason, killing (3) does not cleanup, no idea why.
Pressing ^C does cleanup, so I decided it's good enough.
Line 137: ;;
Line 138: --db-passfile=*)
Line 139: DB_PASSFILE="${v}"
Line 140: [ -r "${DB_PASSFILE}" ] || \
--
To view, visit http://gerrit.ovirt.org/20423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
