Alon Bar-Lev has posted comments on this change.
Change subject: engine,userportal,webadmin: rearrange uris
......................................................................
Patch Set 2:
(5 comments)
OK, your turn... this is the scope, we need to find as many issues as
possible...
Example /ovirt-engine/docs/manual issues strange exception...
I added docs, services, reorg servlets into utils, fix some minor issues,
updated the apache proxy and spec.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java
Line 5: import org.ovirt.engine.ui.uicommonweb.models.vms.INoVnc;
Line 6:
Line 7: public class NoVncImpl extends AbstractVnc implements INoVnc {
Line 8:
Line 9: private static final String CLIENT_PAGE =
"/ovirt-engine/services/novnc-main.html";//$NON-NLS-1$
can we get rid of the hard coded prefix?
Line 10: private final WebsocketProxyConfig config;
Line 11:
Line 12: public NoVncImpl() {
Line 13: this.config = new WebsocketProxyConfig(
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceHtml5Impl.java
Line 5: import org.ovirt.engine.ui.uicommonweb.models.vms.ISpiceHtml5;
Line 6:
Line 7: public class SpiceHtml5Impl extends AbstractSpice implements
ISpiceHtml5 {
Line 8:
Line 9: private static final String CLIENT_PAGE =
"/ovirt-engine/services/spicehtml5-main.html"; //$NON-NLS-1$
can we get rid of the hard coded prefix?
Line 10: private final WebsocketProxyConfig config;
Line 11:
Line 12: public SpiceHtml5Impl() {
Line 13: super();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
Line 23: */
Line 24: public abstract class Configurator {
Line 25:
Line 26: private static final String DOCUMENTATION_LIB_PATH = "html/";
//$NON-NLS-1$
Line 27: private static final String DOCUMENTATION_ROOT =
"ovirt-engine/docs/manual"; //$NON-NLS-1$
can we get rid of the hard coded prefix?
Line 28:
Line 29: private static String documentationLangPath;
Line 30:
Line 31: public static String getDocumentationLangPath() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
Line 28: import com.google.gwt.user.client.ui.TextArea;
Line 29:
Line 30: public abstract class ConsoleModel extends EntityModel {
Line 31: public static final String EjectLabel = "[" +
ConstantsManager.getInstance().getConstants().eject() + "]"; //$NON-NLS-1$
//$NON-NLS-2$
Line 32: public static final String GET_ATTACHMENT_SERVLET_URL =
"/ovirt-engine/services/attachment/"; //$NON-NLS-1$
can we get rid of the hard coded prefix?
Line 33:
Line 34: public static EventDefinition ErrorEventDefinition;
Line 35: private Event privateErrorEvent;
Line 36:
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
Line 65: updateSpiceVersion();
Line 66: }
Line 67:
Line 68: public void updateUsbFilter() {
Line 69: fetchFile("/ovirt-engine/services/files/usbfilter.txt",
usbFilterFileFetchedEvent); //$NON-NLS-1$
can we get rid of the hard coded prefix?
Line 70: }
Line 71:
Line 72: @Override
Line 73: public void configure(ISpice spice) {
--
To view, visit http://gerrit.ovirt.org/20473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
