Alon Bar-Lev has posted comments on this change.
Change subject: engine,userportal,webadmin: rearrange uris
......................................................................
Patch Set 5:
(1 comment)
NICE!
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/NoVncImpl.java
Line 7:
Line 8: public class NoVncImpl extends AbstractVnc implements INoVnc {
Line 9:
Line 10: private static final String CLIENT_PAGE =
HostPageConfiguration.getInstance().getBaseContextPath()
Line 11: + "services/novnc-main.html"; //$NON-NLS-1$
can we not relay that the function return trailing '/'? it will make it easier
to replace it with context root of /ovirt-engine/xxx at all places.
Line 12: private final WebsocketProxyConfig config;
Line 13:
Line 14: public NoVncImpl() {
Line 15: this.config = new WebsocketProxyConfig(
--
To view, visit http://gerrit.ovirt.org/20473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cb4822f6bf4d372715e12858635db5ed3edd115
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
