Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-backup: Safer password input
......................................................................
Patch Set 9:
(1 comment)
....................................................
File packaging/bin/engine-backup.sh
Line 74: The database access password can also be passed using the
Line 75: environment variable OVIRT_ENGINE_DATABASE_PASSWORD . For security
Line 76: reasons it's recommended to use --db-password or
--db-passfile=file.
Line 77: Using --db-password=password is the least secure option, as the
Line 78: password can be seen using 'ps'.
why do we need text? are we educating administrators? should openssl add this
text as well when printing help? do we need also to put it in setup as we allow
password via environment?
Please leave only:
ENVIRONMENT VARIABLES
OVIRT_ENGINE_DATABASE_PASSWORD
Database password as if provided by --db-password=pass parameter.
Line 79:
Line 80: To create a new user/database:
Line 81:
Line 82: create user <user> password '<password>';
--
To view, visit http://gerrit.ovirt.org/20423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc497af2653417beab54a9be307332cdf69a48a
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
