Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: refactoring
......................................................................


Patch Set 3:

> Did you check how this nesting affects the logs? 

it seems that the nesting directory is transparent to the logs:

 otopi.plugins.ovirt_engine_setup.all-in-one.storage.Plugin._init

where the file is:
 
/usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/storage.py

so if the ordering is done at method level and not at file level, anything 
should be changed.

-- 
To view, visit http://gerrit.ovirt.org/20293
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I572da9cd7b4a2b9e1fdfee4c05e83a0ca31b99bc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to