Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: refactoring
......................................................................
Patch Set 3:
(3 comments)
....................................................
File ovirt-engine.spec.in
Line 764:
Line 765: %files lib
Line 766: %{engine_data}/bin/java-home
Line 767: %{python_sitelib}/ovirt_engine/
Line 768: #
hmmm... I am unsure we want this in lib... maybe have ovirt-engine-pki?
keep in mind that this is now going out of versionlock so we need to support
backward compatibility.
but... why do we need to move it anyway?
Line 769: # PKI
Line 770: #
Line 771: # Most directories are owned by the engine user because
Line 772: # it needs to create files inside
Line 881: %{engine_data}/setup/plugins/ovirt-engine-remove/ovirt-engine/
Line 882: %{engine_data}/setup/plugins/ovirt-engine-rename/
Line 883:
Line 884: %files setup-plugin-ovirt-engine-common
Line 885: %config %{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging.conf
this 10-packaging should be at core setup as it is configuration of the setup
it-self. maybe we need multiple of these... 10-packaging-jboss...
how come there are no plugin here?
Line 886:
Line 887:
Line 888: %files setup-plugin-websocket-proxy
Line 889:
Line 883:
Line 884: %files setup-plugin-ovirt-engine-common
Line 885: %config %{_sysconfdir}/ovirt-engine-setup.conf.d/10-packaging.conf
Line 886:
Line 887:
extra space
Line 888: %files setup-plugin-websocket-proxy
Line 889:
Line 890: %{engine_data}/firewalld/base/ovirt-websocket-proxy.xml.in
Line 891: %{engine_data}/setup/plugins/ovirt-engine-common/websocket_proxy/
--
To view, visit http://gerrit.ovirt.org/20293
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I572da9cd7b4a2b9e1fdfee4c05e83a0ca31b99bc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
