Alexander Wels has posted comments on this change.

Change subject: userportal, webadmin: converted docs mapping files to properties
......................................................................


Patch Set 1:

>> Strange question, wouldn't it be less error prone during parsing to instead 
>> of a java property file, return a json file with key/value pairs, and just 
>> map it with a dictionary?

>need to keep in mind that the people that will update/maintain the contents of 
>this mapping file wouldn't necessarily be developers (but documentation 
>maintainers or similar) - I think that the .properties file format is a little 
>bit more friendly for them in that sense, but I could be wrong.

I understand that, but it should be pretty trivial to have a servlet read the 
property file (Just a resource bundle), and generate the appropriate JSON from 
that. That way the maintainers get the property file, while the application 
gets a dictionary.

-- 
To view, visit http://gerrit.ovirt.org/20793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b96d005684007125d5f3940abdbec25d4cae81f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to