Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: converted docs mapping files to properties ......................................................................
Patch Set 3: Hi! Thanks! My usual stupid questions... 1. why can't we store the format in json to begin with? 2. we do not need to commit file with just empty values if we provide a script to generate a complete file. 3. please consider to move the servlets out of /manual name space. 4. please consider to use the branding application name as a key to which file to load. 5. I really wish to be able to move to proper hierarchy within the data file, even if we need to modify the code and add metadata... but ignore this for now. Thanks -- To view, visit http://gerrit.ovirt.org/20793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b96d005684007125d5f3940abdbec25d4cae81f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
