Alissa Bonas has posted comments on this change.
Change subject: core: allow identical path for different local domains
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java
Line 64:
Line 65: protected boolean
isConnWithSameDetailsExists(StorageServerConnections connection) {
Line 66: List<StorageServerConnections> connections = null;
Line 67: if (connection.getstorage_type() == StorageType.LOCALFS) {
Line 68: Guid storagePoolId =
getStoragePoolIdByConnId(connection.getid());
I think a more simple flow can be done here for local connection:
1. get connections by connection path (like for file domains) supplied to this
command.
2. if there is any conn with same path (or more than one ) - get their ids, and
with them do the dc validation via the storage pool api similar to what you did.
because if vds is not specified (and it can be not specified starting 3.3 - see
Allon's changes on this issue), then this validation will be useless in most
cases.
Line 69: connections = storagePoolId == null ?
Collections.<StorageServerConnections> emptyList() :
Line 70:
getStorageConnDao().getAllConnectableStorageSeverConnection(storagePoolId);
Line 71: }
Line 72: else if (connection.getstorage_type().isFileDomain()) {
--
To view, visit http://gerrit.ovirt.org/20886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
