Alissa Bonas has posted comments on this change.
Change subject: core: allow identical path for different local domains
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java
Line 52: protected List<StorageDomain> getStorageDomainsByConnId(String
connectionId) {
Line 53: return
getStorageDomainDao().getAllByConnectionId(Guid.createGuidFromString(connectionId));
Line 54: }
Line 55:
Line 56: protected Guid getStoragePoolIdByConnId(String connectionId) {
not correct results for iscsi... better to rename it
Line 57: List<StorageDomain> storageDomains =
getStorageDomainsByConnId(connectionId);
Line 58: if (storageDomains.isEmpty()) {
Line 59: return null;
Line 60: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommandTest.java
Line 254: }
Line 255:
Line 256: @Test
Line 257: public void isLocalDomainConnWithSamePathExist() {
Line 258: StorageServerConnections localConnection =
populateBasicConnectionDetails("/localSD", StorageType.LOCALFS);
rename to something like newlocalConn
Line 259: StorageServerConnections existingConn =
populateBasicConnectionDetails("/localSD", StorageType.LOCALFS);
Line 260: existingConn.setid(Guid.newGuid().toString());
Line 261:
Line 262: List<StorageServerConnections> connections = new
ArrayList<>();
--
To view, visit http://gerrit.ovirt.org/20886
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4628d7fa442b959d5582e44386f31518b98852e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
