Alon Bar-Lev has posted comments on this change.

Change subject: packaging: gluster:Hide irrelevant fields in configuration 
preview during setup
......................................................................


Patch Set 6:

> When Application mode is set as gluster only mode then it disables Datacenter 
> tab in UI, so showing datacenter related information will confuse the users. 
> Yes we need to show the Application mode to the user.

so we can not initialize the storage type?

    def _misc(self):
        self.environment[osetupcons.DBEnv.STATEMENT].execute(
            statement="""
                select inst_update_default_storage_pool_type (%(type)s)
            """,
            args={
                'type': self.STORAGE_TYPES[
                    self.environment[osetupcons.ConfigEnv.STORAGE_TYPE]
                ],
            },
        )

if so, please add condition not to call this stage if gluster, and do not put 
anything at customization if gluster.

-- 
To view, visit http://gerrit.ovirt.org/20955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to