Alon Bar-Lev has posted comments on this change. Change subject: packaging: gluster:Hide irrelevant fields in configuration preview during setup ......................................................................
Patch Set 6: (1 comment) I do not understand... so you patch downstream not to ask something, but you patch upstream to hide it? won't it better to either do this downstream or upstream? a proper solution is to install environment file at spec file like we do for all-in-one and jboss location, so that setup loads that and sets its defaults. this way you can only patch spec file at downstream. anyway, I do not see any value hiding the application mode. for the nfs, hide it not because it is gluster but because nfs config is false. .................................................... Commit Message Line 3: AuthorDate: 2013-11-06 15:09:27 +0530 Line 4: Commit: Sandro Bonazzola <[email protected]> Line 5: CommitDate: 2013-11-06 14:02:00 +0100 Line 6: Line 7: packaging: gluster:Hide irrelevant fields in configuration preview during setup packaging: setup: please Line 8: Line 9: Few fields like NFS setup, Application mode and Datacentre storage Line 10: type are not relevant when application mode is gluster. So they will Line 11: not be displayed under configuration preview during engine-setup if -- To view, visit http://gerrit.ovirt.org/20955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Darshan N <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
