Mike Kolesnik has posted comments on this change.
Change subject: core: Fixed GetAllDisksByVmIdQueryTest
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java
Line 134: private DiskImage createDiskSnapshots(Guid diskId) {
Maybe createDiskSnapshot without the s is more appropriate.
Line 179: assertEquals("Wrong snapshot " + i + " for disk ",
disk.getId(), disk.getSnapshots().get(i).getImageId());
You compare disk id to image id, which is not the same thing.
--
To view, visit http://gerrit.ovirt.org/3817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib069780c99a04317a02d5017764c15528f931846
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
